fix(api) fix output of records in /plugins/schema #4162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hishamhm
force-pushed
the
fix/plugin-schema-fields
branch
from
8b7ab79 to
47da971
Compare
hishamhm
changed the title
thibaultcha
requested changes
Jan 7, 2019
hishamhm
force-pushed
the
fix/plugin-schema-fields
branch
from
47da971 to
0e49cb2
Compare
|
@thibaultcha Review addressed! Thanks for the tip about |
thibaultcha
reviewed
Jan 7, 2019
* Ensure that plugin schemas return sub-fields of nested records in the same format as the toplevel `fields` entry (i.e., as an array of single-fields objects, so that the field order can be retrieved). * Ensure `fields` in `/plugins/schema` always returns a JSON array, even when it is empty (as in the prometheus plugin). This produces an incompatible output from that of 1.0.0, but the one in 1.0.0 is arguably broken, so this produces the intended result. Fixes #4137.
hishamhm
force-pushed
the
fix/plugin-schema-fields
branch
from
0e49cb2 to
8fa9a1e
Compare
thibaultcha
approved these changes
Jan 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
format as the toplevel
fieldsentry (i.e., as an array of single-fieldsobjects, so that the field order can be retrieved).
fieldsin/plugins/schemaalways returns a JSON array,even when it is empty (as in the prometheus plugin).
This produces an incompatible output from that of 1.0.0, but I'm opening this against
masterbecause the one in 1.0.0 is arguably broken, so this produces the intended result.Fixes #4137.